Ensure entity visibility operations run safely on main thread#19
Open
goul4rt wants to merge 1 commit intoMagmaGuy:masterfrom
Open
Ensure entity visibility operations run safely on main thread#19goul4rt wants to merge 1 commit intoMagmaGuy:masterfrom
goul4rt wants to merge 1 commit intoMagmaGuy:masterfrom
Conversation
…y, PlayerDisguiseEntity, and SkeletonWatchers to ensure they run on the main thread, preventing potential concurrency issues.
goul4rt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a concurrency issue where entity visibility methods (showEntity, hideEntity, etc.) were being called from non-primary threads, potentially causing thread-safety violations or runtime exceptions on Bukkit-based servers.
The changes enforce that all visibility updates are executed on the main thread, using Bukkit.isPrimaryThread() checks and Bukkit.getScheduler().runTask(...) scheduling when necessary.
Exampel of logs erros fixes: https://mclo.gs/rrAXuPM